leerho commented on PR #476: URL: https://github.com/apache/datasketches-cpp/pull/476#issuecomment-3886316366
@proost, Could you please explain the purpose of the third-party library by Nemanja Trifunovic, that you have added, and your reasoning as to why it is absolutely necessary. I would like to discourage adding third-party dependencies in our code base (especially non-standard ones) as it complicates code integration, debugging, and maintenance. In C++, we use the C++ Standard Library, Boost, XxHash64, and public domain MurmurHash3, all of which are extremely well known and tested. I'm not so sure about this code from Nemanja Trifunovic. Is it versioned? Does it follow a rigorous release process? Is it maintained? Do we absolutely have to have it? His License header is non-standard, we may need to have it approved. And even if you could convince me that it is required, we would need to update the LICENSE file, at minimum. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
