proost commented on PR #476: URL: https://github.com/apache/datasketches-cpp/pull/476#issuecomment-3901461866
@leerho First, the code included in this PR is derived from UTF8-CPP (https://github.com/nemtrif/utfcpp). I followed the installation and usage guidance from the repository. > Is this just a C++ issue? Are there similar issues in Rust, Go, Python? From what I understand: - Rust, and Python string types represent Unicode text. So It might be encoded to UTF-8(I'm not sure. because I don't know Rust or Python well) - In Go, `string` is a byte array and may contain invalid UTF-8 unless explicitly validated. - In C++, `std::string` is also a character array and does not enforce UTF-8 validity. So this is mainly a concern for languages where "string" is not guaranteed to be valid Unicode text unless validated explicitly. > This concern would apply to any of our sketches that SerDe strings and not just Tuple... I agree. If we decide to introduce UTF-8 validation, it would make sense to implement it as a shared utility and apply it consistently across all sketches that serialize or deserialize string data, not just Tuple. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
