leerho commented on PR #567:
URL: https://github.com/apache/datasketches-cpp/pull/567#issuecomment-6904000756

   Thanks for the rework, and for adding the lifetime notes.
   
   On timing: the bug-fix release (5.3.1) went out on Nov 13. The next one will 
be a minor release, probably 5.4.0, once we've landed the open PRs (we may have 
to draw a line somewhere). It comes before the larger refactor that will become 
6.0.0. I can't give a firm date, because it depends on how fast those PRs land.
   
   I checked the new version against Java's `IncludeMinMax`: on 7,500 random 
KLL sketches (floats and strings, merged sketches, many duplicates), the sorted 
view's items and cumulative weights matched Java's in every case, including the 
4,795 that needed an adjustment. I also merged it into current master locally 
and ran all tests under ASan and UBSan: they pass. There is one small conflict 
with master, in the `get_sorted_view()` doc comment in `kll_sketch.hpp`, where 
#558 added "An empty sketch returns an empty view without allocating item 
storage." Keeping both lines resolves it. Could you merge master into the 
branch, or would you like us to do it?
   
   On scope: KLL only is fine for this PR, since it keeps the review 
manageable. But Java includes the exact min and max in classic quantiles and 
REQ too, and I don't want a release where C++ KLL does this and the other two 
don't. So I'd like classic quantiles and REQ to follow as separate PRs before 
5.4.0. If you can't do those, please let us know and we'll take them on.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to