stojkomilos commented on PR #567:
URL: https://github.com/apache/datasketches-cpp/pull/567#issuecomment-6913122547

   @leerho 
   
   > On scope: KLL only is fine for this PR, since it keeps the review 
manageable. But Java includes the exact min and max in classic quantiles and 
REQ too, and I don't want a release where C++ KLL does this and the other two 
don't. So I'd like classic quantiles and REQ to follow as separate PRs before 
5.4.0. If you can't do those, please let us know and we'll take them on.
   
   I don't really use these 2 sketches (I only use KLL), so I would have to 
learn how they work and other details about them. So I would prefer if you take 
it on, that would be great :D
   
   > here is one small conflict with master, in the `get_sorted_view()` doc 
comment in `kll_sketch.hpp`, where #558 added "An empty sketch returns an empty 
view without allocating item storage." Keeping both lines resolves it. Could 
you merge master into the branch, or would you like us to do it?
   
   This is pushed now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to