SnowMoon-Dev commented on issue #2130: URL: https://github.com/apache/incubator-devlake/issues/2130#issuecomment-1151862446
> The use case doesn't seem legit. Why would authentication get passed by `task.options`? It should be with `connection` and handled by `ApiClient.SetBeforeFunction`, Check `plugins/github/tasks/api_client.go` for detail. Do you have any actual cases to prove the necessity of this PR? The previous idea was to get the token information in the configuration file env from the context of the task, and later @warren830 gave me a better suggestion -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
