e2corporation commented on code in PR #2146:
URL: https://github.com/apache/incubator-devlake/pull/2146#discussion_r896865391
##########
config-ui/src/pages/configure/connections/ConnectionForm.jsx:
##########
@@ -216,14 +216,14 @@ export default function ConnectionForm (props) {
id='connection-name'
inputRef={connectionNameRef}
disabled={isTesting || isSaving || isLocked}
- readOnly={[Providers.GITLAB,
Providers.JENKINS].includes(activeProvider.id)}
+ readOnly={sourceLimits[activeProvider.id]}
placeholder={placeholders ? placeholders.name : 'Enter Instance
Name'}
value={name}
onChange={(e) => onNameChange(e.target.value)}
// className={`input connection-name-input
${fieldHasError('Connection') ? 'invalid-field' : ''}`}
// className='input connection-name-input'
className={`input connection-name-input ${stateErrored ===
'connection-name' ? 'invalid-field' : ''}`}
- leftIcon={[Providers.GITLAB,
Providers.JENKINS].includes(activeProvider.id) ? 'lock' : null}
+ leftIcon={sourceLimits[activeProvider.id] ? 'lock' : null}
Review Comment:
(Same as above on 219)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
