e2corporation commented on code in PR #2146:
URL: https://github.com/apache/incubator-devlake/pull/2146#discussion_r896864663
##########
config-ui/src/pages/configure/connections/ConnectionForm.jsx:
##########
@@ -216,14 +216,14 @@ export default function ConnectionForm (props) {
id='connection-name'
inputRef={connectionNameRef}
disabled={isTesting || isSaving || isLocked}
- readOnly={[Providers.GITLAB,
Providers.JENKINS].includes(activeProvider.id)}
+ readOnly={sourceLimits[activeProvider.id]}
Review Comment:
I don't know if this is the best use of `sourceLimits` because we could
limit a provider to just 2 or 3 instances, this is just checking if it has a
sourceLimit defined and locking the field to `readOnly`. It would need to be
more specific to that `sourceLimit` is equal to `1`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
