klesh commented on code in PR #2215:
URL: https://github.com/apache/incubator-devlake/pull/2215#discussion_r910839937
##########
helpers/e2ehelper/data_flow_tester.go:
##########
@@ -73,6 +74,18 @@ type DataFlowTester struct {
Log core.Logger
}
+type TableOptions struct {
Review Comment:
This is a good idea, but I think it would be better to keep the logic of the
`test-cases` simple. If the positive conditions are good enough, we don't want
negative conditions because it adds complexity. Complexity brings bugs. We
don't want `test-cases` to be buggy...
##########
helpers/e2ehelper/data_flow_tester.go:
##########
@@ -73,6 +74,18 @@ type DataFlowTester struct {
Log core.Logger
}
+type TableOptions struct {
+ // relative path to the CSV file that contains the seeded data
+ CSVRelPath string
+ // the fields (columns) to consider for verification. Leave empty to
default to all.
+ TargetFields []string
+ // the fields (columns) to ignore/skip.
+ IgnoreFields []string
+ // similar to IgnoreFields, this will ignore the fields contained in
the type. Useful for ignoring embedded types and
Review Comment:
Please follow the `godoc` specification: The comment of
`field`/`method`/`func` should start with its name
In this case: `IgnoreTypes is similar to IgnoreFields ...`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
