keon94 commented on code in PR #2215:
URL: https://github.com/apache/incubator-devlake/pull/2215#discussion_r911172460
##########
helpers/e2ehelper/data_flow_tester.go:
##########
@@ -73,6 +74,18 @@ type DataFlowTester struct {
Log core.Logger
}
+type TableOptions struct {
Review Comment:
By negative conditions do you mean the "Ignore" fields? Right now, I'm using
that to ignore the common PK fields for validation. It felt cumbersome to
manually specify all the struct fields each time. Also, with CreateSnapshot()
we had to go and manually remove the unwanted Raw columns from the CSV that
were getting generated from the DB. This way that's automatically taken care of
too. That's also what motivated this.
But this logic shouldn't need any changes to other test cases. The old
VerifyTable function signature/behavior is the same as before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
