klesh commented on code in PR #2215:
URL: https://github.com/apache/incubator-devlake/pull/2215#discussion_r912600366
##########
helpers/e2ehelper/data_flow_tester_test.go:
##########
@@ -68,3 +72,142 @@ func ExampleDataFlowTester() {
},
)
}
+
+func TestGetTableMetaData(t *testing.T) {
+ var gitlab core.PluginMeta
+ dataflowTester := NewDataFlowTester(t, "github", gitlab)
+
+ t.Run("get_fields", func(t *testing.T) {
+ fields := dataflowTester.getFields(&models.GithubIssueLabel{},
func(column gorm.ColumnType) bool {
Review Comment:
This creates unnecessary coupling to `models.GithubIssueLabel`, I suggest
you define a struct within this test and use it in this test file, and this
test file only.
##########
helpers/e2ehelper/data_flow_tester_test.go:
##########
@@ -68,3 +72,142 @@ func ExampleDataFlowTester() {
},
)
}
+
+func TestGetTableMetaData(t *testing.T) {
+ var gitlab core.PluginMeta
+ dataflowTester := NewDataFlowTester(t, "github", gitlab)
+
+ t.Run("get_fields", func(t *testing.T) {
+ fields := dataflowTester.getFields(&models.GithubIssueLabel{},
func(column gorm.ColumnType) bool {
Review Comment:
Otherwise, whenever `models.GithubIssueLabel` gets modified, this test case
would need to be updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
