mindlesscloud commented on code in PR #2587:
URL: https://github.com/apache/incubator-devlake/pull/2587#discussion_r930987622
##########
plugins/jira/tasks/apiv2models/user.go:
##########
@@ -46,6 +46,10 @@ func (u *Account) getAccountId() string {
if u.AccountId != "" {
return u.AccountId
}
+ //TODO add this code,run success,no test for jira cloud
+ if u.Name != "" {
+ return u.Name
Review Comment:
The accountId is a primary key of table `_tool_jira_accounts`, it should be
unique. How about we leave it alone and modify the Collector `CollectAccounts`.
For the server version Jira, the endpoint `api/2/user/search` should be invoked
instead of `api/2/user` which only accepts a username, not an email. Please be
cautious about the response of the API `api/2/user/search`, which is an array,
not an object. So the `ResponseParser` should also be adjusted accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
