mindlesscloud commented on code in PR #2587:
URL: https://github.com/apache/incubator-devlake/pull/2587#discussion_r940165551
##########
plugins/jira/tasks/apiv2models/user.go:
##########
@@ -46,6 +46,10 @@ func (u *Account) getAccountId() string {
if u.AccountId != "" {
return u.AccountId
}
+ //TODO add this code,run success,no test for jira cloud
+ if u.Name != "" {
+ return u.Name
Review Comment:
There is one difference between the response of the two endpoints. For
`api/2/user`, it is an object, however, the response of `api/2/user/search` is
an array. The collector's `ResponseParser` should be modified to handle both
cases. The collector returns a slice of interface `[]interface{}`, and every
item of the slice is a user object. There is no need to change the extractor
for it always receives a single user object.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
