e2corporation commented on code in PR #2887:
URL: https://github.com/apache/incubator-devlake/pull/2887#discussion_r959339865
##########
config-ui/src/hooks/useConnectionManager.jsx:
##########
@@ -282,7 +285,11 @@ function useConnectionManager (
if (!updateMode) {
history.push(`/integrations/${provider.id}`)
}
- } else {
+ }
+ })
+
+ setTimeout(() => {
Review Comment:
If you're going to assign returned save & update promises at this point in
the code-flow then why bother keeping the existing timeout? It would make more
sense to chain a catch call and add then toast a notification on the failure so
the timeout wrap can be removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
