[GitHub] [incubator-devlake] e2corporation commented on a diff in pull request #2887: fix: connection saving must return after 2 seconds even though the ne…

Thu, 01 Sep 2022 05:46:15 -0700 


e2corporation commented on code in PR #2887:
URL: https://github.com/apache/incubator-devlake/pull/2887#discussion_r960609437


##########
config-ui/src/hooks/useConnectionManager.jsx:
##########
@@ -256,13 +256,16 @@ function useConnectionManager (
       }
     }
 
+    let savePromise
     if (updateMode && activeConnection?.id !== null) {
       modifyConfiguration(connectionPayload)
+      savePromise = modifyConfiguration(connectionPayload)

Review Comment:
   ✅ `FIXED` with PR https://github.com/apache/incubator-devlake/pull/2916
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to