e2corporation commented on code in PR #2926:
URL: https://github.com/apache/incubator-devlake/pull/2926#discussion_r964764250
##########
config-ui/src/components/blueprints/DataScopesGrid.jsx:
##########
@@ -169,8 +169,8 @@ const DataScopesGrid = (props) => {
padding: 0,
}}
>
- {c.boards.map((board, bIdx) => (
- <li key={`list-item-key-${bIdx}`}>{board}</li>
+ {c.boardsList.map((board, bIdx) => (
Review Comment:
More refinements and property consolidation on the data scope connection
model will be done later, especially with regard to duplicated props. Ideally
we want to build the same data scope connection for both advanced and normal,
due to the differences in how advanced data is referenced currently these
"connection" objects constructed in different ways even though they are sharing
the same model.
Regardless of this, `boards` has always referenced _selected_ boards and
`boardsList` anywhere in the code base has always reflected the _available_
list of boards.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
