[GitHub] [incubator-devlake] e2corporation commented on pull request #2926: feat: add projects selector fetching by api for gitlab when adding blueprint

[GitBox]

e2corporation commented on PR #2926:
URL: 
https://github.com/apache/incubator-devlake/pull/2926#issuecomment-1239437333

   @likyh Functional tests looking good, the selector operates nicely so far. I 
think there are some visual tweaks we may want to consider. I do like that Full 
Repository Path is shown, but maybe we want to consider shortening the nodes 
displayed to just the repo name and it's immediate parent for multi-level 
scenarios? **-or-** we need some CSS tweaks on the Stacked Project List 
selector to handle lengthy project paths, mainly by css truncation+ellipsis to 
prevent a rendering bug.
   
   The other useful thing that can be done, is for the TagItem renderer 
callback we can customize the selector tags that get inserted into the widget. 
We could wrap them with a tooltip or popover that contains the full repository 
path and other project details. This way we can just show the Project Name 
alone for the tag.
   
   <img width="794" alt="Screen Shot 2022-09-07 at 9 57 56 AM" 
src="https://user-images.githubusercontent.com/1742233/188897907-0176402a-0c96-49d0-8df3-20e125dfb5c9.png";>
   
   <img width="825" alt="Screen Shot 2022-09-07 at 9 57 48 AM" 
src="https://user-images.githubusercontent.com/1742233/188897873-2c5c3c6c-6508-4468-b06f-e397b616cdb9.png";>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@devlake.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org