mintsweet commented on code in PR #3191:
URL: https://github.com/apache/incubator-devlake/pull/3191#discussion_r980655311
##########
config-ui/src/components/blueprints/transformations/CICD/Deployment.jsx:
##########
@@ -40,17 +40,25 @@ const Deployment = (props) => {
useEffect(() => {
setSelectValue(
transformation?.deploymentPattern ||
- transformation?.deploymentPattern === ''
+ transformation?.deploymentPattern === '' ||
+ transformation?.productionPattern ||
+ transformation?.productionPattern === ''
? 1
: 0
)
- }, [transformation?.deploymentPattern])
+ }, [transformation?.deploymentPattern, transformation?.productionPattern])
const handleChangeSelectValue = (sv) => {
if (entityIdKey && sv === 0) {
- onSettingsChange({ deploymentPattern: undefined }, entityIdKey)
+ onSettingsChange(
+ { deploymentPattern: undefined, productionPattern: undefined },
Review Comment:
**deploymentPattern** and **productionPattern** are empty strings by
default, DORA-related tasks will be executed at this time, and default by the
backend will convert their values. when the request does not have these two
parameters, DORA-related tasks Tasks will not be executed, set to undefined in
the request parameters, and they will not be brought into the request
parameters.
If using an extra parameter to manage them, I think this would incur
additional maintenance costs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
