[GitHub] [incubator-devlake] e2corporation commented on a diff in pull request #3191: fix(config-ui): adjust the parameters so the devlake can not execute DORA tasks

Wed, 28 Sep 2022 06:37:23 -0700 


e2corporation commented on code in PR #3191:
URL: https://github.com/apache/incubator-devlake/pull/3191#discussion_r982417915


##########
config-ui/src/components/blueprints/transformations/CICD/Deployment.jsx:
##########
@@ -40,17 +40,25 @@ const Deployment = (props) => {
   useEffect(() => {
     setSelectValue(
       transformation?.deploymentPattern ||
-        transformation?.deploymentPattern === ''
+        transformation?.deploymentPattern === '' ||
+        transformation?.productionPattern ||
+        transformation?.productionPattern === ''
         ? 1
         : 0
     )
-  }, [transformation?.deploymentPattern])
+  }, [transformation?.deploymentPattern, transformation?.productionPattern])
 
   const handleChangeSelectValue = (sv) => {
     if (entityIdKey && sv === 0) {
-      onSettingsChange({ deploymentPattern: undefined }, entityIdKey)
+      onSettingsChange(
+        { deploymentPattern: undefined, productionPattern: undefined },

Review Comment:
   Linting was also not run prior to finalizing this PR, and a missing Effect 
dependency has caused new warning.
   
   <img width="800" alt="Screen Shot 2022-09-28 at 9 35 17 AM" 
src="https://user-images.githubusercontent.com/1742233/192792968-ff073739-098a-4817-b462-1624698659fb.png";>
   
   
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to