matrixji commented on PR #3695: URL: https://github.com/apache/incubator-devlake/pull/3695#issuecomment-1306804241
> LGTM, and is there any other char in name? As [repository names](https://github.com/dead-claudia/github-limits#repository-names) described: > All code points must be either a hyphen (-), an underscore (_), a period (.), or an ASCII alphanumeric code point current pattern: `/([a-z0-9_-]){2,}\/([.a-z0-9_-]){2,}$/gi` should be OK for all cases. And as [Usernames](https://github.com/dead-claudia/github-limits#usernames), [Organization names](https://github.com/dead-claudia/github-limits#organization-names) and [Team names](https://github.com/dead-claudia/github-limits#team-names) says dot(.) and dash(-) is not allowed. Actually, the pattern for the name part: `([a-z0-9_-]){2,}` is more relaxed than what is actually needed. IMO, it is acceptable, as this pattern is just a filter for some basic checks on UI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
