klesh commented on code in PR #3952:
URL: 
https://github.com/apache/incubator-devlake/pull/3952#discussion_r1050322022


##########
plugins/jira/e2e/issue_test.go:
##########
@@ -183,6 +185,15 @@ func TestIssueDataFlow(t *testing.T) {
                },
        )
 
+       dataflowTester.VerifyTable(
+               models.JiraIssueLabel{},
+               "./snapshot_tables/_tool_jira_issue_labels.csv",
+               []string{

Review Comment:
   _raw_data_* fields should be verified as well.



##########
plugins/jira/e2e/snapshot_tables/issue_labels.csv:
##########
@@ -0,0 +1,19 @@
+issue_id,label_name,_raw_data_params,_raw_data_table,_raw_data_id,_raw_data_remark

Review Comment:
   The _raw_data_* fields is missing



##########
plugins/jira/tasks/issue_label_convertor.go:
##########
@@ -0,0 +1,82 @@
+/*
+Licensed to the Apache Software Foundation (ASF) under one or more
+contributor license agreements.  See the NOTICE file distributed with
+this work for additional information regarding copyright ownership.
+The ASF licenses this file to You under the Apache License, Version 2.0
+(the "License"); you may not use this file except in compliance with
+the License.  You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package tasks
+
+import (
+       "reflect"
+
+       "github.com/apache/incubator-devlake/errors"
+       "github.com/apache/incubator-devlake/models/domainlayer/didgen"
+       "github.com/apache/incubator-devlake/models/domainlayer/ticket"
+       "github.com/apache/incubator-devlake/plugins/core"
+       "github.com/apache/incubator-devlake/plugins/core/dal"
+       "github.com/apache/incubator-devlake/plugins/helper"
+       "github.com/apache/incubator-devlake/plugins/jira/models"
+)
+
+var ConvertIssueLabelsMeta = core.SubTaskMeta{
+       Name:             "convertIssueLabels",
+       EntryPoint:       ConvertIssueLabels,
+       EnabledByDefault: true,
+       Description:      "Convert tool layer table jira_issue_labels into  
domain layer table issue_labels",
+       DomainTypes:      []string{core.DOMAIN_TYPE_TICKET},
+}
+
+func ConvertIssueLabels(taskCtx core.SubTaskContext) errors.Error {
+       db := taskCtx.GetDal()
+       data := taskCtx.GetData().(*JiraTaskData)
+
+       cursor, err := db.Cursor(

Review Comment:
   `BoardId` is missing



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to