[GitHub] [incubator-devlake] mindlesscloud opened a new pull request, #4090: fix: fix the canceling does not work when SkipOnFail is set to true

Tue, 03 Jan 2023 05:58:56 -0800 


mindlesscloud opened a new pull request, #4090:
URL: https://github.com/apache/incubator-devlake/pull/4090

   ### Summary
   Fix the bug that canceling does not work when `SkipOnFail` is set to true
   - make sure every task returns the error `context.Canceled` when it is 
canceled
   - if the error is`context.Canceled`, return it despite the value of 
`SkipOnFail`
   
   ### Screenshots
   
![image](https://user-images.githubusercontent.com/8455907/210371535-705572b6-4d29-4e5b-acdd-489f634faf30.png)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to