mindlesscloud commented on code in PR #4090:
URL:
https://github.com/apache/incubator-devlake/pull/4090#discussion_r1061079753
##########
plugins/helper/api_collector.go:
##########
@@ -168,7 +168,8 @@ func (collector *ApiCollector) Execute() errors.Error {
break
}
}
- input, err := iterator.Fetch()
+ var input interface{}
+ input, err = iterator.Fetch()
Review Comment:
this snippet is sitting inside a for loop, the statement `input, err :=
iterator.Fetch()` would declare a new local variable `err` which shadows the
original `err`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
