mindlesscloud commented on code in PR #4301:
URL:
https://github.com/apache/incubator-devlake/pull/4301#discussion_r1116644751
##########
backend/helpers/e2ehelper/data_flow_tester.go:
##########
@@ -119,7 +119,7 @@ func NewDataFlowTester(t *testing.T, pluginName string,
pluginMeta plugin.Plugin
// ImportCsvIntoRawTable imports records from specified csv file into target
raw table, note that existing data would be deleted first.
func (t *DataFlowTester) ImportCsvIntoRawTable(csvRelPath string, rawTableName
string) {
- csvIter := pluginhelper.NewCsvFileIterator(csvRelPath)
+ csvIter, _ := pluginhelper.NewCsvFileIterator(csvRelPath)
Review Comment:
As a testing helper function, it could throw panic if something went wrong.
However, as a function called by the plugin, it would be better to return an
error and let the caller decides how to handle it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
