mindlesscloud commented on code in PR #4301:
URL:
https://github.com/apache/incubator-devlake/pull/4301#discussion_r1116655674
##########
backend/helpers/pluginhelper/csv_file_iterator.go:
##########
@@ -67,21 +74,30 @@ func (ci *CsvFileIterator) Close() {
// HasNext returns a boolean to indicate whether there was any row to be
`Fetch`
func (ci *CsvFileIterator) HasNext() bool {
+ hasNext, err := ci.HasNextWithError()
+ if err != nil {
+ panic(err)
Review Comment:
No, if you wish the error to be returned instead of panic, please use the
new function `HasNextWithError`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
