[GitHub] [incubator-devlake] abeizn commented on a diff in pull request #4759: Gitlab token check

Fri, 24 Mar 2023 03:08:13 -0700 


abeizn commented on code in PR #4759:
URL: 
https://github.com/apache/incubator-devlake/pull/4759#discussion_r1147370210


##########
backend/plugins/gitlab/api/connection.go:
##########
@@ -49,11 +51,24 @@ func TestConnection(input *plugin.ApiResourceInput) 
(*plugin.ApiResourceOutput,
                return nil, err
        }
 
-       _, err = api.NewApiClientFromConnection(context.TODO(), basicRes, 
&connection)
+       apiClient, err := api.NewApiClientFromConnection(context.TODO(), 
basicRes, &connection)
        if err != nil {
                return nil, err
        }
 
+       // check API/read_api permissions

Review Comment:
   https://devlake.apache.org/docs/next/Configuration/GitLab
   
![image](https://user-images.githubusercontent.com/101256042/227492016-191f061a-51c8-4e52-8934-b799fd254e09.png)
   
   Does this also verify read_user and read_repository  permission?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to