abeizn commented on code in PR #4759:
URL:
https://github.com/apache/incubator-devlake/pull/4759#discussion_r1147424176
##########
backend/plugins/gitlab/api/connection.go:
##########
@@ -49,11 +51,24 @@ func TestConnection(input *plugin.ApiResourceInput)
(*plugin.ApiResourceOutput,
return nil, err
}
- _, err = api.NewApiClientFromConnection(context.TODO(), basicRes,
&connection)
+ apiClient, err := api.NewApiClientFromConnection(context.TODO(),
basicRes, &connection)
if err != nil {
return nil, err
}
+ // check API/read_api permissions
Review Comment:
you are right, the docs need to update
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
