klesh commented on code in PR #5501:
URL: 
https://github.com/apache/incubator-devlake/pull/5501#discussion_r1233494316


##########
backend/plugins/gitlab/tasks/mr_extractor.go:
##########
@@ -51,6 +51,8 @@ type MergeRequestRes struct {
        MergedAt        *api.Iso8601Time `json:"merged_at"`
        ClosedAt        *api.Iso8601Time `json:"closed_at"`
        MergeCommitSha  string           `json:"merge_commit_sha"`
+       SquashCommitSha string           `json:"squash_commit_sha"`
+       DiffHeadSha     string           `json:"diff_head_sha"`

Review Comment:
   @Marco-De-Stefani Thanks. I checked the Gitlab REST doc, looks like the 
field `diff_head_sha` doesn't exist. 
   According to the `sha` field description from 
https://docs.gitlab.com/ee/api/merge_requests.html#response, I think it is the 
correct one we need.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to