Marco-De-Stefani commented on code in PR #5501:
URL:
https://github.com/apache/incubator-devlake/pull/5501#discussion_r1233572009
##########
backend/plugins/gitlab/tasks/mr_extractor.go:
##########
@@ -51,6 +51,8 @@ type MergeRequestRes struct {
MergedAt *api.Iso8601Time `json:"merged_at"`
ClosedAt *api.Iso8601Time `json:"closed_at"`
MergeCommitSha string `json:"merge_commit_sha"`
+ SquashCommitSha string `json:"squash_commit_sha"`
+ DiffHeadSha string `json:"diff_head_sha"`
Review Comment:
@klesh Fixed.
I have a question though, from my API tests it seems that that field is
always populated (the other 2 are populated only when the MR is merged, this
one is always there and gets updated), could that cause some issues down the
line?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
