keon94 commented on code in PR #5609:
URL: 
https://github.com/apache/incubator-devlake/pull/5609#discussion_r1251060170


##########
backend/core/errors/util.go:
##########
@@ -28,3 +28,17 @@ func Is(err, target error) bool {
 func As(err error, target any) bool {
        return errors.As(err, &target)
 }
+
+func Must(err error) {

Review Comment:
   Are you using this to remove error handling boilerplate? Panics are 
generally to be avoided if possible
   Also I'd call this function "Assert", like in other languages



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to