keon94 commented on code in PR #5609:
URL:
https://github.com/apache/incubator-devlake/pull/5609#discussion_r1251066634
##########
backend/impls/dalgorm/dalgorm_transaction.go:
##########
@@ -48,6 +50,56 @@ func (t *DalgormTransaction) Commit() errors.Error {
return nil
}
+func (t *DalgormTransaction) LockTables(tables map[string]bool) errors.Error {
Review Comment:
For better readbility and future-proofing, I suggest you change the input of
this function from map to []struct where the struct has these fields
```
TableName string
LockExclusivity bool
```
or better (to have more compile time safety)
```
Tabler dal.Tabler
LockExclusivity bool
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
