abeizn commented on code in PR #6127:
URL:
https://github.com/apache/incubator-devlake/pull/6127#discussion_r1332742269
##########
backend/plugins/bamboo/e2e/snapshot_tables/cicd_deployment_commits.csv:
##########
@@ -1,8 +1,8 @@
-id,commit_sha,cicd_scope_id,cicd_deployment_id,name,result,status,environment,created_date,started_date,finished_date,duration_sec,ref_name,repo_id,repo_url,prev_success_deployment_commit_id
Review Comment:
Are these time parameters gone?
##########
backend/core/models/domainlayer/devops/cicd_pipeline.go:
##########
@@ -51,50 +53,88 @@ const (
// this is for the field `status` in table.cicd_pipelines and table.cicd_tasks
const (
+ STATUS_NOT_STARTED = "NOT_STARTED"
STATUS_IN_PROGRESS = "IN_PROGRESS"
+ STATUS_BLOCKED = "BLOCKED"
STATUS_DONE = "DONE"
)
type ResultRule struct {
- Success []string
- Failed []string
- Abort []string
- Manual []string
- Skipped []string
- Default string
+ Success []string
+ Failed []string
+ Abort []string
+ Manual []string
+ Skipped []string
+ Default string
+ CaseInsensitive bool
Review Comment:
Isn't the CaseInsensitive parameter necessary? Because you have set it to
true (CaseInsensitive: true) by default in the converter, users cannot set it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
