d4x1 commented on code in PR #6127:
URL: 
https://github.com/apache/incubator-devlake/pull/6127#discussion_r1333143898


##########
backend/core/models/domainlayer/devops/cicd_pipeline.go:
##########
@@ -51,50 +53,88 @@ const (
 
 // this is for the field `status` in table.cicd_pipelines and table.cicd_tasks
 const (
+       STATUS_NOT_STARTED = "NOT_STARTED"
        STATUS_IN_PROGRESS = "IN_PROGRESS"
+       STATUS_BLOCKED     = "BLOCKED"
        STATUS_DONE        = "DONE"
 )
 
 type ResultRule struct {
-       Success []string
-       Failed  []string
-       Abort   []string
-       Manual  []string
-       Skipped []string
-       Default string
+       Success         []string
+       Failed          []string
+       Abort           []string
+       Manual          []string
+       Skipped         []string
+       Default         string
+       CaseInsensitive bool

Review Comment:
   `CaseInsensitive`'s default value if false, which means "Abc" is different 
from "abc", that is the default behavior of current function.
   Is `CaseInsensitive` is set to true, "Abc" and "abc" are the same.
   
   



##########
backend/core/models/domainlayer/devops/cicd_pipeline.go:
##########
@@ -51,50 +53,88 @@ const (
 
 // this is for the field `status` in table.cicd_pipelines and table.cicd_tasks
 const (
+       STATUS_NOT_STARTED = "NOT_STARTED"
        STATUS_IN_PROGRESS = "IN_PROGRESS"
+       STATUS_BLOCKED     = "BLOCKED"
        STATUS_DONE        = "DONE"
 )
 
 type ResultRule struct {
-       Success []string
-       Failed  []string
-       Abort   []string
-       Manual  []string
-       Skipped []string
-       Default string
+       Success         []string
+       Failed          []string
+       Abort           []string
+       Manual          []string
+       Skipped         []string
+       Default         string
+       CaseInsensitive bool

Review Comment:
   @abeizn 
   `CaseInsensitive`'s default value if false, which means "Abc" is different 
from "abc", that is the default behavior of current function.
   Is `CaseInsensitive` is set to true, "Abc" and "abc" are the same.
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to