Technoboy- commented on a change in pull request #1716: Fix bug: Use
try-with-resources or close this "Socket" in a "finally" clause.
URL:
https://github.com/apache/incubator-dolphinscheduler/pull/1716#discussion_r363077895
##########
File path:
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/utils/FourLetterWordMain.java
##########
@@ -59,23 +59,22 @@ public static String send4LetterWord(String host, int
port, String cmd)
*/
public static String send4LetterWord(String host, int port, String cmd,
int timeout)
throws IOException {
- LOG.info("connecting to " + host + " " + port);
- Socket sock = new Socket();
+ LOG.info("connecting to {0} {1}", host, port);
Review comment:
why {0}, {1} ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
