Jave-Chen commented on a change in pull request #1716: Fix bug: Use
try-with-resources or close this "Socket" in a "finally" clause.
URL:
https://github.com/apache/incubator-dolphinscheduler/pull/1716#discussion_r363083044
##########
File path:
dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/worker/task/sql/SqlTask.java
##########
@@ -101,7 +101,7 @@ public void handle() throws Exception {
// set the name of the current thread
String threadLoggerInfoName =
String.format(Constants.TASK_LOG_INFO_FORMAT, taskProps.getTaskAppId());
Thread.currentThread().setName(threadLoggerInfoName);
- logger.info(sqlParameters.toString());
+ logger.info("{}", sqlParameters);
Review comment:
> could we add more prefix message ,like :
>
> ```
> logger.info("sqlParameters {}", sqlParameters);
> ```
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
