Technoboy- commented on a change in pull request #1717: Refactor Alert module
#1694
URL:
https://github.com/apache/incubator-dolphinscheduler/pull/1717#discussion_r363078185
##########
File path:
dolphinscheduler-alert/src/main/java/org/apache/dolphinscheduler/alert/AlertServer.java
##########
@@ -73,4 +76,37 @@ public static void main(String[] args){
alertServer.start();
}
+ /**
+ * send alert message
+ * @param alerts waiting list
+ */
+ private void send(List<Alert> alerts) {
Review comment:
Suggestion:
AlerServer should not has this send, put it to other class
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
