Technoboy- commented on a change in pull request #1717: Refactor Alert module
#1694
URL:
https://github.com/apache/incubator-dolphinscheduler/pull/1717#discussion_r363568060
##########
File path:
dolphinscheduler-alert/src/main/java/org/apache/dolphinscheduler/alert/AlertServer.java
##########
@@ -73,4 +76,37 @@ public static void main(String[] args){
alertServer.start();
}
+ /**
+ * send alert message
+ * @param alerts waiting list
+ */
+ private void send(List<Alert> alerts) {
Review comment:
> yes, I want to remove the logic of regularly scanning the DB in the second
step and then decouple the AlertServer class and the Send method.
Merging your pr will affect all the developer. Even though refactor can
split into more steps, but every step should code nice .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
