zhongjiajie commented on code in PR #99:
URL:
https://github.com/apache/dolphinscheduler-sdk-python/pull/99#discussion_r1284005473
##########
src/pydolphinscheduler/__init__.py:
##########
@@ -17,4 +17,4 @@
"""Init root of pydolphinscheduler."""
-__version__ = "4.1.0-dev"
+__version__ = "4.0.3"
Review Comment:
please revert this change
##########
src/pydolphinscheduler/core/task.py:
##########
@@ -251,24 +246,17 @@ def timeout_flag(self) -> str:
"""Whether the timeout attribute is being set or not."""
return TaskTimeoutFlag.ON if self._timeout else TaskTimeoutFlag.OFF
- @property
- def is_cache(self) -> str:
- """Whether the cache is being set or not."""
- if isinstance(self._is_cache, bool):
- return IsCache.YES if self._is_cache else IsCache.NO
- else:
- raise PyDSParamException("is_cache must be a bool")
-
@property
def resource_list(self) -> List[Dict[str, Resource]]:
"""Get task define attribute `resource_list`."""
resources = set()
for res in self._resource_list:
+
if type(res) == str:
resources.add(
Resource(
name=res, user_name=self.user_name
- ).get_fullname_from_database()
+ ).get_id_from_database()
Review Comment:
hi @Treasure-u in the latest dev code, we use resource file full path as
identify instead of resource id, so in python-sdk python code we will also use
full path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
