Treasure-u commented on code in PR #99:
URL:
https://github.com/apache/dolphinscheduler-sdk-python/pull/99#discussion_r1320771630
##########
src/pydolphinscheduler/core/task.py:
##########
@@ -251,24 +246,17 @@ def timeout_flag(self) -> str:
"""Whether the timeout attribute is being set or not."""
return TaskTimeoutFlag.ON if self._timeout else TaskTimeoutFlag.OFF
- @property
- def is_cache(self) -> str:
- """Whether the cache is being set or not."""
- if isinstance(self._is_cache, bool):
- return IsCache.YES if self._is_cache else IsCache.NO
- else:
- raise PyDSParamException("is_cache must be a bool")
-
@property
def resource_list(self) -> List[Dict[str, Resource]]:
"""Get task define attribute `resource_list`."""
resources = set()
for res in self._resource_list:
+
if type(res) == str:
resources.add(
Resource(
name=res, user_name=self.user_name
- ).get_fullname_from_database()
+ ).get_id_from_database()
Review Comment:
thanks for your reply, im sorry it's too late to reply you,i know it and
with pydolphin can do better and better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
