Orange-Summer commented on code in PR #14702:
URL:
https://github.com/apache/dolphinscheduler/pull/14702#discussion_r1293604390
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/utils/DependentExecute.java:
##########
@@ -267,12 +300,44 @@ public DependResult getModelDependResult(Date
currentTime, int testFlag) {
DependResult dependResult = getDependResultForItem(dependentItem,
currentTime, testFlag);
if (dependResult != DependResult.WAITING && dependResult !=
DependResult.FAILED) {
dependResultMap.put(dependentItem.getKey(), dependResult);
+ if (dependentItem.getParameterPassing() &&
!dependItemVarPoolPropertyMap.isEmpty()) {
+ addTaskVarPool(dependItemVarPoolPropertyMap,
dependItemVarPoolEndTimeMap,
+ dependTaskVarPoolPropertyMap,
dependTaskVarPoolEndTimeMap);
+ }
}
+ dependItemVarPoolPropertyMap.clear();
+ dependItemVarPoolEndTimeMap.clear();
Review Comment:
For each dependItem in dependItemList, I will store the obtained varPool and
endTime into these two Maps, merge the data into the
`dependTaskVarPoolPropertyMap` and then empty it, and then used for the next
loop. I can't find a better way, because I can't get dependResult before😅
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/utils/DependentExecute.java:
##########
@@ -267,12 +300,44 @@ public DependResult getModelDependResult(Date
currentTime, int testFlag) {
DependResult dependResult = getDependResultForItem(dependentItem,
currentTime, testFlag);
if (dependResult != DependResult.WAITING && dependResult !=
DependResult.FAILED) {
dependResultMap.put(dependentItem.getKey(), dependResult);
+ if (dependentItem.getParameterPassing() &&
!dependItemVarPoolPropertyMap.isEmpty()) {
+ addTaskVarPool(dependItemVarPoolPropertyMap,
dependItemVarPoolEndTimeMap,
+ dependTaskVarPoolPropertyMap,
dependTaskVarPoolEndTimeMap);
+ }
}
+ dependItemVarPoolPropertyMap.clear();
+ dependItemVarPoolEndTimeMap.clear();
Review Comment:
For each dependItem in dependItemList, I will store the obtained varPool and
endTime into these two Maps, merge the data into the
`dependTaskVarPoolPropertyMap` and then empty it, and then used for the next
loop. I can't find a better way, because I can't get dependResult before😅
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
