Radeity commented on code in PR #14702:
URL:
https://github.com/apache/dolphinscheduler/pull/14702#discussion_r1293616563
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/utils/DependentExecute.java:
##########
@@ -267,12 +300,44 @@ public DependResult getModelDependResult(Date
currentTime, int testFlag) {
DependResult dependResult = getDependResultForItem(dependentItem,
currentTime, testFlag);
if (dependResult != DependResult.WAITING && dependResult !=
DependResult.FAILED) {
dependResultMap.put(dependentItem.getKey(), dependResult);
+ if (dependentItem.getParameterPassing() &&
!dependItemVarPoolPropertyMap.isEmpty()) {
+ addTaskVarPool(dependItemVarPoolPropertyMap,
dependItemVarPoolEndTimeMap,
+ dependTaskVarPoolPropertyMap,
dependTaskVarPoolEndTimeMap);
+ }
}
+ dependItemVarPoolPropertyMap.clear();
+ dependItemVarPoolEndTimeMap.clear();
Review Comment:
Oh, I'm not familiar with dependent task logic, but if you make sure there's
no concurrent issue, I'm ok with that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
