zhongjiajie commented on code in PR #14876:
URL:
https://github.com/apache/dolphinscheduler/pull/14876#discussion_r1318405435
##########
dolphinscheduler-task-plugin/dolphinscheduler-task-shell/src/main/java/org/apache/dolphinscheduler/plugin/task/shell/ShellTask.java:
##########
@@ -81,7 +81,7 @@ public void init() {
public void handle(TaskCallBack taskCallBack) throws TaskException {
try {
IShellInterceptorBuilder<?, ?> shellActuatorBuilder =
ShellInterceptorBuilderFactory.newBuilder()
-
.properties(ParameterUtils.convert(shellParameters.getLocalParametersMap()))
+
.properties(ParameterUtils.convert(taskExecutionContext.getPrepareParamsMap()))
Review Comment:
it will not, `taskExecutionContext.getPrepareParamsMap()` including all
parameter, such as startup param, global param, and local's
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
