ruanwenjun commented on code in PR #14876:
URL:
https://github.com/apache/dolphinscheduler/pull/14876#discussion_r1319273341
##########
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/expand/CuringParamsServiceImpl.java:
##########
@@ -69,8 +70,13 @@ public class CuringParamsServiceImpl implements
CuringParamsService {
private ProjectParameterMapper projectParameterMapper;
@Override
- public String convertParameterPlaceholders(String val, Map<String, String>
allParamMap) {
- return ParameterUtils.convertParameterPlaceholders(val, allParamMap);
+ public String convertParameterPlaceholders(String val, Map<String,
Property> allParamMap) {
+ Map<String, String> paramMap = allParamMap
+ .entrySet()
+ .stream()
+ .filter(entry -> nonNull(entry.getValue().getValue()))
Review Comment:
I am not clear if we need to filter the null here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
