ruanwenjun commented on code in PR #15174:
URL:
https://github.com/apache/dolphinscheduler/pull/15174#discussion_r1396860744
##########
dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-http/src/main/java/org/apache/dolphinscheduler/plugin/alert/http/HttpAlertChannelFactory.java:
##########
@@ -79,7 +79,15 @@ public List<PluginParams> params() {
.build())
.build();
- return Arrays.asList(url, requestType, headerParams, bodyParams,
contentField);
+ InputParam timeout =
Review Comment:
Please use InputNumberParam` is better, and use `setValue1 to set default
value to 120.
##########
dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-http/src/main/java/org/apache/dolphinscheduler/plugin/alert/http/HttpSender.java:
##########
@@ -108,8 +113,15 @@ public AlertResult send(String msg) {
}
public String getResponseString(HttpRequestBase httpRequest) throws
IOException {
- CloseableHttpClient httpClient =
-
HttpClients.custom().setRetryHandler(HttpServiceRetryStrategy.retryStrategy).build();
+ RequestConfig requestConfig = RequestConfig.custom()
Review Comment:
Use TimeUnit to convert s to ms or directly use timeout * 1000 is ok, no
need to define
NUMBER_1000
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
