qingwli commented on code in PR #15174:
URL:
https://github.com/apache/dolphinscheduler/pull/15174#discussion_r1396978114
##########
dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-http/src/main/java/org/apache/dolphinscheduler/plugin/alert/http/HttpAlertChannelFactory.java:
##########
@@ -79,7 +79,15 @@ public List<PluginParams> params() {
.build())
.build();
- return Arrays.asList(url, requestType, headerParams, bodyParams,
contentField);
+ InputParam timeout =
Review Comment:
Done
##########
dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-http/src/main/java/org/apache/dolphinscheduler/plugin/alert/http/HttpSender.java:
##########
@@ -108,8 +113,15 @@ public AlertResult send(String msg) {
}
public String getResponseString(HttpRequestBase httpRequest) throws
IOException {
- CloseableHttpClient httpClient =
-
HttpClients.custom().setRetryHandler(HttpServiceRetryStrategy.retryStrategy).build();
+ RequestConfig requestConfig = RequestConfig.custom()
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
