ruanwenjun commented on code in PR #15190:
URL:
https://github.com/apache/dolphinscheduler/pull/15190#discussion_r1400344789
##########
dolphinscheduler-dao/src/main/resources/org/apache/dolphinscheduler/dao/mapper/CommandMapper.xml:
##########
@@ -43,7 +43,7 @@
<select id="queryCommandPageBySlot"
resultType="org.apache.dolphinscheduler.dao.entity.Command">
select *
from t_ds_command
- where id % #{masterCount} = #{thisMasterSlot}
+ where unix_timestamp(update_time) % #{masterCount} = #{thisMasterSlot}
Review Comment:
If there is new database setup, means there is a new ds cluster deploy? So
you don't want to restart the old ds cluster?
I just worry `md5` is not supported by all database. `where
conv(left(md5(id), 4), 16, 10) % #{masterCount} = #{thisMasterSlot}`.
Can we select a batch command from database e.g. `select * from t_ds_command
limit 100`.
And filter the command at memory? We can provide some filter strategies, e.g
hash_by_id(hash by id)、md5_by_id(use md5 to change the id and then do hash).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
