ruanwenjun commented on code in PR #15190:
URL:
https://github.com/apache/dolphinscheduler/pull/15190#discussion_r1401608172
##########
dolphinscheduler-dao/src/main/resources/org/apache/dolphinscheduler/dao/mapper/CommandMapper.xml:
##########
@@ -43,7 +43,7 @@
<select id="queryCommandPageBySlot"
resultType="org.apache.dolphinscheduler.dao.entity.Command">
select *
from t_ds_command
- where id % #{masterCount} = #{thisMasterSlot}
+ where unix_timestamp(update_time) % #{masterCount} = #{thisMasterSlot}
Review Comment:
Ok, so we all agree filter the command which should be consumed at memory
rather than using database to do this kind of work, then we can support complex
logic to `shuffle` the command.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
