zhongjiajie commented on PR #130: URL: https://github.com/apache/dolphinscheduler-sdk-python/pull/130#issuecomment-1874781972
BTW, since it is an incompatible change, we should add some comments in https://github.com/apache/dolphinscheduler-sdk-python/blob/1b2ad576eef87430e0abee47cce60eec5a374475/UPDATING.md#L29 we already have some example in that. And we better add some `DeprecationWarning` for the user who still passes old parameter type for it. the old parameter seems like ```py http = Http( name="http", url="http://www.google.com";, http_method="GET", http_params=[ {"prop": "abc", "httpParametersType": "PARAMETER", "value": "def"} ], ) ``` And we should raise some warnings and tell users that the format is deprecation https://github.com/apache/dolphinscheduler-sdk-python/blob/e1d15274a6ffc2cf2ee3236d3ba3e8a0b1cf70d3/src/pydolphinscheduler/core/task.py#L202-L207 maybe it can be ```py if isinstance(http_params, list): warnings.warn( "The `http_params` parameter currently accept dict instead of list, you parameter is ignore.", DeprecationWarning, ) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
