HarshitNagpal29 commented on code in PR #130:
URL:
https://github.com/apache/dolphinscheduler-sdk-python/pull/130#discussion_r1440364617
##########
src/pydolphinscheduler/tasks/http.py:
##########
@@ -82,8 +106,27 @@ def __init__(
raise PyDSParamException(
"Parameter http_method %s not support.", http_method
)
+
+ if isinstance(http_params, list):
+ warnings.warn(
+ "The `http_params` parameter currently accepts a dictionary
instead of a list. Your parameter is being ignored.",
+ DeprecationWarning,
+ )
+
self.http_method = http_method
- self.http_params = http_params or []
+ self.http_params = http_params # Storing the original value
+
+ @property
+ def http_params(self):
+ """Property to convert http_params using ParameterHelper when
accessed."""
+ return ParameterHelper.convert_params(self._http_params,
direction=Direction.IN) if self._http_params else []
+
+ @http_params.setter
+ def http_params(self, value):
+ """Setter method for http_params."""
+ self._http_params = value
+
+
Review Comment:
@zhongjiajie sir done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
