fuchanghai commented on code in PR #15802:
URL:
https://github.com/apache/dolphinscheduler/pull/15802#discussion_r1554776015
##########
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/constants/Constants.java:
##########
@@ -735,4 +735,14 @@ private Constants() {
* K8S sensitive param
*/
public static final String K8S_CONFIG_REGEX = "(?<=((?i)configYaml(\" :
\"))).*?(?=(\",\\n))";
+
+
+ /**
+ * netty config enable
+ */
+ public static final String NETTY_SSL_ENABLE = "netty.ssl.enable";
+
+ public static final String NETTY_SSL_KEY_PATH = "netty.ssl.key.path";
+
+ public static final String NETTY_SSL_CERT_PATH = "netty.ssl.cert.path";
Review Comment:
i add config into common.properties,Because if the master service uses SSL
authentication, the worker must also be configured。 so i think only config into
common better than config both into master and worker
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]