rickchengx commented on code in PR #15802:
URL:
https://github.com/apache/dolphinscheduler/pull/15802#discussion_r1556838353
##########
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/constants/Constants.java:
##########
@@ -735,4 +735,14 @@ private Constants() {
* K8S sensitive param
*/
public static final String K8S_CONFIG_REGEX = "(?<=((?i)configYaml(\" :
\"))).*?(?=(\",\\n))";
+
+
+ /**
+ * netty config enable
+ */
+ public static final String NETTY_SSL_ENABLE = "netty.ssl.enable";
+
+ public static final String NETTY_SSL_KEY_PATH = "netty.ssl.key.path";
+
+ public static final String NETTY_SSL_CERT_PATH = "netty.ssl.cert.path";
Review Comment:
Overall LGTM, Even if these configs are in `common.properties`, the
`common.properties` of the master and worker may have different configs. I
think it is necessary to deal with the inconsistency in encryption.
So I agree with @ruanwenjun that we could move these configs to
`application.yaml`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
